Skip to content

platform: preserve diagnostics and require restart consent - #20

Closed
rwang23 wants to merge 1 commit into
Codex/audit-pr01-hermetic-testsfrom
Codex/audit-pr06-platform-diagnostics
Closed

platform: preserve diagnostics and require restart consent#20
rwang23 wants to merge 1 commit into
Codex/audit-pr01-hermetic-testsfrom
Codex/audit-pr06-platform-diagnostics

Conversation

@rwang23

@rwang23 rwang23 commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Audit remediation

Implements audit PR-06 for actionable platform diagnostics and a safe restart flow.

  • discovery failures are returned as typed diagnostics rather than collapsed into “not installed”
  • Windows asks the selected target to close normally and waits before any escalation
  • an explicit second confirmation is required before the force-close path; cancellation preserves the current target and theme state
  • macOS persistence hosts are restricted to /Applications and the current user’s ~/Applications

Verification

  • npm run desktop:check (30 Rust tests)
  • npm run test:source
  • node --check apps/theme-manager/src/renderer/app.js
  • node --check apps/theme-manager/src/renderer/bridge.js
  • git diff --check

Independent acceptance pass

Pass with risks: source and Rust acceptance checks cover typed discovery failures, normal-close-first behavior, escalation authorization, cancellation state, and macOS host validation. A real isolated Tauri/UI smoke test against Stable/Beta and a live Windows graceful/force-close lifecycle are intentionally not run here, so those remain required before release.

Closes #9

@rwang23

rwang23 commented Jul 27, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #26, now merged into main at e2ed6e8. This branch head is already included in main; closing the draft avoids duplicate review and merge work.

@rwang23 rwang23 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant